Fixes for backup remote exports and annex drop #3639
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
nellh
commented
Nov 11, 2025
nellh
commented
- Block less often with async coroutines for S3 export tasks
- Fix an issue with credentials that would cause drop to fail depending on how the s3 remote was configured
- Fix a bug with an extra argument for the fsck / drop pipeline
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #3639 +/- ##
=======================================
Coverage 42.98% 42.99%
=======================================
Files 635 635
Lines 33809 33817 +8
Branches 1518 1518
=======================================
+ Hits 14534 14538 +4
- Misses 19136 19140 +4
Partials 139 139 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
effigies
reviewed
Nov 11, 2025
Comment on lines
+7
to
+21
| if env: | ||
| process = await asyncio.create_subprocess_exec( | ||
| *command, | ||
| cwd=dataset_path, | ||
| env=env, | ||
| stdout=asyncio.subprocess.PIPE, | ||
| stderr=asyncio.subprocess.PIPE, | ||
| ) | ||
| else: | ||
| process = await asyncio.create_subprocess_exec( | ||
| *command, | ||
| cwd=dataset_path, | ||
| stdout=asyncio.subprocess.PIPE, | ||
| stderr=asyncio.subprocess.PIPE, | ||
| ) |
Contributor
There was a problem hiding this comment.
The default value of env is already None: https://docs.python.org/3/library/subprocess.html#subprocess.Popen
Suggested change
| if env: | |
| process = await asyncio.create_subprocess_exec( | |
| *command, | |
| cwd=dataset_path, | |
| env=env, | |
| stdout=asyncio.subprocess.PIPE, | |
| stderr=asyncio.subprocess.PIPE, | |
| ) | |
| else: | |
| process = await asyncio.create_subprocess_exec( | |
| *command, | |
| cwd=dataset_path, | |
| stdout=asyncio.subprocess.PIPE, | |
| stderr=asyncio.subprocess.PIPE, | |
| ) | |
| process = await asyncio.create_subprocess_exec( | |
| *command, | |
| cwd=dataset_path, | |
| env=env, | |
| stdout=asyncio.subprocess.PIPE, | |
| stderr=asyncio.subprocess.PIPE, | |
| ) |
Did you find this made a difference in practice?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.